if you have a will, trust etc. do you still need the service of an elder law atty.

The short answer is "Maybe not." It depends on what your goals are and what issues you are facing at any given time.  "Regular" estate planning with a trust focuses primarily on distributing your assets according to your wishes at your death and avoiding probate. An elder law attorney can inform you of issues that you may not have even considered, like long-term care planning (nursing home planning), for instance.