Is it a viable reason to pull me over if I nearly pulled out in front of a state trooper from a stop?

I live in New York State and recently was pulled over after I nearly pulled out in front of a state trooper from a stop. I did not actually pull out, although the front tip of my car may have been on or barely past the white line of the side of the road. When he pulled me over he asked for my license as registration and than berated me for nearly killing him his partner and his dog. After my sincere apology's, he than contended that he smelled pot and asked me if there was anything in the car. After I consistently denied the presence of pot in my car and even offered him the approval to search if he wanted, he even threatened to have the dog scratch and tear my car. Finally, he decided not to search me anyway than wrote me a ticket for failure to notify the Department of motor vehicle of an address change on my license. My question is, did he have the right to pull me over in the first place , or was it illegal for him to terrorize me as such?